up2date

icinga2/init.sls

@@ -1,3 +1,5 @@
+include:
+  - nginx
 
 icinga_packages:
   pkg.installed:

salt/minion.sls

@@ -1,25 +1,25 @@
 include:
   - salt.update
 
-/lib/systemd/system/salt-minion.service:
+#/lib/systemd/system/salt-minion.service:
-  file.managed:
+#  file.managed:
-    - source: salt://salt/files/salt-minion.service
+#    - source: salt://salt/files/salt-minion.service
-    - user: root
+#    - user: root
-    - group: root
+#    - group: root
-    - mode: 644
+#    - mode: 644
 
-systemd reload for salt-minion:
+#systemd reload for salt-minion:
-  module.run:
+#  module.run:
-    - name: service.systemctl_reload
+#    - name: service.systemctl_reload
-    - onchanges:
+#    - onchanges:
-      - file: /lib/systemd/system/salt-minion.service
+#      - file: /lib/systemd/system/salt-minion.service
 
-salt-minion:
+#salt-minion:
-  service.running:
+#  service.running:
-    - enable: true
+#    - enable: true
-    - require:
+#    - require:
-      - file: /lib/systemd/system/salt-minion.service
+#      - file: /lib/systemd/system/salt-minion.service
-      - module: systemd reload for salt-minion
+#      - module: systemd reload for salt-minion
 
 /etc/salt/minion:
   file.managed:

salt/update.sls

@@ -1,4 +1,4 @@
-salt:
+#salt:
-  pip.installed:
+#  pip.installed:
-    - user: root
+#    - user: root
-    - upgrade: true
+#    - upgrade: true

samba/files/smb.conf.jinja

@@ -1,6 +1,6 @@
 #
 # Managed by Salt
-#
+# TODO: this could use file.serialize
 # run testparm -s after making changes to validate them
 
 [global]
@@ -10,27 +10,37 @@
   logging = file
   panic action = /usr/share/samba/panic-action %d
   server role = standalone server
-  obey pam restrictions = yes
+  obey pam restrictions = no
   unix password sync = no
   map to guest = bad user
   usershare max shares = 0
   encrypt passwords = yes
   smb encrypt = required
+  create mask = 0775
+  directory mask = 0775
+  force user = {{ pillar.samba.force_user }}
+  force group = {{ pillar.samba.force_group }}
+  vfs object = recycle
+  recycle:repository = /mnt/keir/recycle/%U
+  recycle:touch = Yes
+  recycle:keeptree = Yes
+  recycle:versions = Yes
+  recycle:noversions = *.tmp,*.temp,*.o,*.obj,*.TMP,*.TEMP
+  recycle:exclude = *.tmp,*.temp,*.o,*.obj,*.TMP,*.TEMP
+  recycle:excludedir = /recycle,/tmp,/temp,/TMP,/TEMP
 
 {% if salt.pillar.get('samba:enable_homes', false) %}
 [homes]
   comment = Home Directories
   browseable = no
   read only = yes
-  create mask = 0700
-  directory mask = 0700
   valid users = %S
 {% endif %}
 
 {% for name, conf in salt.pillar.get('samba:shares', {}).items() %}
 [{{ name }}]
-  path = {{ conf['path'] }}
+  {%- for key, val in conf.items() %}
-  valid users = {{ conf['users'] }}
+  {{ key }} = {{ val }}
-  read only = {{ conf['readonly'] }}
+  {%- endfor %}
 {% endfor %}
 

users/files/authorized_keys.jinja

@@ -0,0 +1,3 @@
+{% for comment, key in salt.pillar.get('authorized_keys')[user].items() -%}
+{{ key }} {{ comment }}
+{% endfor -%}

users/init.sls

@@ -1,20 +1,26 @@
 
-{% if salt.pillar.get('root_authorized_keys', None) is not none %}
+{% for user in salt.pillar.get('authorized_keys').keys() %}
-/root/.ssh:
+  {% set home = '' if user == 'root' else '/home' %}
+
+{{ home }}/{{ user }}/.ssh:
   file.directory:
-    - user: root
+    - user: {{ user }}
-    - group: root
+    - group: {{ user }}
     - mode: 700
 
-/root/.ssh/authorized_keys:
+{{ home }}/{{ user }}/.ssh/authorized_keys:
   file.managed:
-    - contents_pillar: root_authorized_keys
+    - template: jinja
-    - user: root
+    - source: salt://users/files/authorized_keys.jinja
-    - group: root
+    - user: {{ user }}
+    - group: {{ user }}
     - mode: 400
+    - context:
+        user: {{ user }}
     - require:
-      - file: /root/.ssh
+      - file: {{ home }}/{{ user }}/.ssh
-{% endif %}
+
+{% endfor %}
 
 {% if salt.pillar.get('manage_root_bashrc', False) %}
 /root/.bashrc:
@@ -71,27 +77,6 @@
       - user: {{ user }}_user
 {% endif %}
 
-{% if 'authorized_keys' in data or 'ssh_config' in data %}
-/home/{{ user }}/.ssh:
-  file.directory:
-    - user: {{ user }}
-    - group: {{ user }}
-    - mode: 0700
-    - require:
-      - user: {{ user }}_user
-{% endif %}
-
-{% if 'authorized_keys' in data %}
-/home/{{ user }}/.ssh/authorized_keys:
-  file.managed:
-    - contents_pillar: users:{{ user }}:authorized_keys
-    - user: {{ user }}
-    - group: {{ user }}
-    - mode: 0400
-    - require:
-      - file: /home/{{ user }}/.ssh
-{% endif %}
-
 {% if 'ssh_config' in data %}
 /home/{{ user }}/.ssh/config:
   file.managed: