lookup homedirs

restic/init.sls

@@ -73,7 +73,7 @@ restic scripts:
 
 restic cron:
   cron.present:
-    - name: "/opt/restic/backup.sh 2>&1 >/dev/null"
+    - name: "/opt/restic/backup.sh >/dev/null 2>&1"
     - identifier: restic backup
     - minute: random
     - hour: 4

users/init.sls

@@ -12,7 +12,6 @@
 {% endif %}
 
 {% for user, config in salt.pillar.get('users', {}).items() %}
-
 {{ user }}_user:
   user.present:
     - name: {{ user }}
@@ -24,7 +23,14 @@
   {% endfor %}
 
   {% if config.get('manage_bashrc', False) %}
-/home/{{ user }}/.bashrc:
+    {% set homedir = salt.user.info(user).get('home', None) %}
+    {% if homedir is none %}
+{{ "~%s/.bashrc" | format(user) }}:
+  test.fail_without_changes:
+    - name: {{ "No homedir for %s - if they were created in this run, run this state again" | format(user) }}
+    {% else %}
+
+{{ homedir }}/.bashrc:
   file.managed:
     - source: 'salt://users/files/bashrc.jinja'
     - template: jinja
@@ -36,6 +42,6 @@
     - require:
       - user: {{ user }}_user
     {% endif %}
-
+  {% endif %}
 {% endfor %}
 

vim/init.sls

@@ -3,18 +3,21 @@
 {{ vim.pkg }}:
   pkg.installed: []
 
-/root/.vimrc:
-  file.managed:
-    - source: 'salt://vim/files/vimrc'
-    - user: root
-    - group: root
-    - mode: 644
+{% set vim_users = salt.pillar.get('users', {}) | list %}
+{% do vim_users.append('root') %}
 
-{% for user in salt.pillar.get('users', []) %}
-/home/{{ user }}/.vimrc:
+{% for user in vim_users %}
+  {% set homedir = salt.user.info(user).get('home', None) %}
+  {% if homedir is none %}
+{{ "~%s/.vimrc" | format(user) }}:
+  test.fail_without_changes:
+    - name: {{ "No homedir for %s - if they were created in this run, run this state again" | format(user) }}
+  {% else %}
+{{ homedir }}/.vimrc:
   file.managed:
     - source: 'salt://vim/files/vimrc'
     - user: {{ user }}
     - group: {{ user }}
     - mode: 644
+  {% endif %}
 {% endfor %}